add support Lease-based leader election (rather than ConfigMaps) #1877 by rvlane · Pull Request #2314 · kubernetes-client/python

rvlane · 2024-12-17T22:40:02Z

What type of PR is this?

/kind feature

What this PR does / why we need it:

Enhance leaderelection module to support V1Lease based lease lock.

Which issue(s) this PR fixes:

Special notes for your reviewer:

Have coded this such that the LeaderElectionRecord is unchanged to ensure backward compatibility with anyone using the existing structures.

Does this PR introduce a user-facing change?

Support Lease-based leader election

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

…rnetes-client#1877 Signed-off-by: Lane Richard <rick.lane@nokia.com>

k8s-ci-robot · 2024-12-17T22:40:05Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: rvlane
Once this PR has been reviewed and has the lgtm label, please assign yliaog for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

kubernetes/base/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

linux-foundation-easycla · 2024-12-17T22:40:06Z

The committers listed above are authorized under a signed CLA.

✅ login: rvlane / name: Rick Lane (bb0c3f4)

k8s-ci-robot · 2024-12-17T22:40:11Z

Welcome @rvlane!

It looks like this is your first PR to kubernetes-client/python 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-client/python has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

rvlane · 2024-12-18T16:17:53Z

@Invictus17 - can you please review this also? Thankis

Invictus17 · 2024-12-19T04:24:03Z

I'm not able to assign myself as reviewer @rvlane.

JacobHenner · 2025-01-06T23:21:34Z

@rvlane do you intend to complete the CLA/can you confirm your contribution is licensed under the Apache License 2.0? I'm interested in adapting it for inclusion in kubernetes_asyncio, but I need to first ensure that its inclusion is legitimate.

Thanks!

rvlane · 2025-01-07T14:09:12Z

@JacobHenner I have been added to my company CLA and have approved the CLA just now.

roycaihw · 2025-01-15T21:05:01Z

/assign @Invictus17 @roycaihw
/cc @Invictus17

k8s-ci-robot · 2025-01-15T21:05:04Z

@roycaihw: GitHub didn't allow me to request PR reviews from the following users: Invictus17.

Note that only kubernetes-client members and repo collaborators can review this PR, and authors cannot review their own PRs.

Details

In response to this:

/assign @Invictus17 @roycaihw
/cc @Invictus17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

k8s-triage-robot · 2025-04-15T21:39:36Z

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

Mark this PR as fresh with /remove-lifecycle stale
Close this PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

JacobHenner · 2025-04-16T01:54:13Z

/remove-lifecycle stale

MadJlzz · 2025-06-16T09:19:19Z

@fabianvf @roycaihw do you need help for the testing/review of this MR? I am interested for this feature as well!

roycaihw

LGTM overall. Could you add a test?

roycaihw · 2025-06-24T19:39:02Z

kubernetes/base/leaderelection/leaderelectionrecord.py


 class LeaderElectionRecord:
-    # Annotation used in the lock object
+    # Lease configuration from in the lock object.


s/from in the/from the

will do, thanks

k8s-triage-robot · 2025-09-22T20:41:52Z

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

Mark this PR as fresh with /remove-lifecycle stale
Close this PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot · 2025-10-22T21:34:56Z

The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

Mark this PR as fresh with /remove-lifecycle rotten
Close this PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

k8s-triage-robot · 2025-11-21T22:17:18Z

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

Reopen this PR with /reopen
Mark this PR as fresh with /remove-lifecycle rotten
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

k8s-ci-robot · 2025-11-21T22:17:21Z

@k8s-triage-robot: Closed this PR.

Details

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied

After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied

After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

Reopen this PR with /reopen

Mark this PR as fresh with /remove-lifecycle rotten

Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

add support Lease-based leader election (rather than ConfigMaps) kube…

bb0c3f4

…rnetes-client#1877 Signed-off-by: Lane Richard <rick.lane@nokia.com>

k8s-ci-robot added the do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. label Dec 17, 2024

k8s-ci-robot requested review from fabianvf and roycaihw December 17, 2024 22:40

k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Dec 17, 2024

rvlane mentioned this pull request Dec 17, 2024

add support Lease-based leader election (rather than ConfigMaps) #1877

Open

rvlane marked this pull request as draft December 19, 2024 13:42

k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 19, 2024

rvlane marked this pull request as ready for review December 19, 2024 13:53

k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 19, 2024

JacobHenner mentioned this pull request Jan 6, 2025

Add leaderelection module tomplus/kubernetes_asyncio#347

Merged

k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jan 7, 2025

k8s-ci-robot assigned Invictus17 and roycaihw Jan 15, 2025

k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 15, 2025

k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 16, 2025

roycaihw added the kind/feature Categorizes issue or PR as related to a new feature. label Jun 24, 2025

k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed needs-kind Indicates a PR lacks a `kind/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. labels Jun 24, 2025

roycaihw reviewed Jun 24, 2025

View reviewed changes

k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 22, 2025

k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Oct 22, 2025

k8s-ci-robot closed this Nov 21, 2025

Conversation

rvlane commented Dec 17, 2024 • edited by roycaihw Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

Uh oh!

k8s-ci-robot commented Dec 17, 2024

Uh oh!

linux-foundation-easycla bot commented Dec 17, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

k8s-ci-robot commented Dec 17, 2024

Uh oh!

rvlane commented Dec 18, 2024

Uh oh!

Invictus17 commented Dec 19, 2024

Uh oh!

JacobHenner commented Jan 6, 2025

Uh oh!

rvlane commented Jan 7, 2025

Uh oh!

roycaihw commented Jan 15, 2025

Uh oh!

k8s-ci-robot commented Jan 15, 2025

Uh oh!

k8s-triage-robot commented Apr 15, 2025

Uh oh!

JacobHenner commented Apr 16, 2025

Uh oh!

MadJlzz commented Jun 16, 2025

Uh oh!

roycaihw left a comment

Choose a reason for hiding this comment

Uh oh!

roycaihw Jun 24, 2025

Choose a reason for hiding this comment

Uh oh!

rvlane Jun 24, 2025

Choose a reason for hiding this comment

Uh oh!

k8s-triage-robot commented Sep 22, 2025

Uh oh!

k8s-triage-robot commented Oct 22, 2025

Uh oh!

k8s-triage-robot commented Nov 21, 2025

Uh oh!

k8s-ci-robot commented Nov 21, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Comments

rvlane commented Dec 17, 2024 •

edited by roycaihw

Loading

linux-foundation-easycla bot commented Dec 17, 2024 •

edited

Loading